Wireshark-bugs: [Wireshark-bugs] [Bug 7860] Add a dissector for the America Online protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 21 Oct 2012 04:22:25 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7860

Tim Hentenaar <tim.hentenaar@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9348|0                           |1
        is obsolete|                            |
   Attachment #9348|review_for_checkin?         |
              Flags|                            |
   Attachment #9390|                            |review_for_checkin?
              Flags|                            |

--- Comment #4 from Tim Hentenaar <tim.hentenaar@xxxxxxxxx> 2012-10-21 04:22:23 PDT ---
Created attachment 9390
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=9390
Updated patch

Hi Evan,

Thanks for the feedback. I've taken your suggestions under advisement, and am
attaching a new patch.

hf_aol_type is still using proto_tree_add_uint. I tried it with
proto_tree_add_item and a bitmask, and it displays as bits and the value, which
makes it look ugly. Is there any way to change how the value's displayed with
proto_tree_add_item? If not, I think it's fine to leave it as is.

I did some googling, and did manage to find some documentation on the frame
protocol that AOL uses. I've added a URL in the comment at the top of the file.

Regards,

Tim

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.