Wireshark-bugs: [Wireshark-bugs] [Bug 7740] Bluetooth: Add AVRCP dissector
Date: Thu, 18 Oct 2012 11:44:53 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7740

Chris Maynard <christopher.maynard@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #7 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2012-10-18 11:44:52 PDT ---
If the offset is out of bounds, both tvb_length_remaining() and 
tvb_reported_length_remaining() return -1.  The code needs to be able to handle
this.  Detected by Coverity and reported as CID 728016: Improper use of
negative value.

Also, in dissect_vendor_dependant():at line 1022, company_id is guaranteed to
be equal to COMPANY_BT_SIG.  Further checks at lines 1031 and 1595 are
therefore unnecessary, and in the latter case, lead to a dead code detection
since the proto_tree_add_item at line 1600 will never be executed.  Detected by
Coverity and reported as CID 728014: Logically dead code.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.