Wireshark-bugs: [Wireshark-bugs] [Bug 7844] Buildbot crash output: fuzz-2012-10-10-4301.pcap
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 10 Oct 2012 17:07:47 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7844

Guy Harris <guy@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Guy Harris <guy@xxxxxxxxxxxx> 2012-10-10 17:07:46 PDT ---
Another loop doing

    for (i = 1; i < N+1; i++)

rather than

    for (i = 0; i < N; i++)

to cause something to be done N times.  If i and N are unsigned, and N has a
value greater than *or equal to* the maximum possible value for i, the first of
those will loop forever and the second of those won't.  Widening the variables
works in some cases, including this one, but it doesn't work if i and N are
already as large as they can be, so the latter idiom is probably the best
choice in all cases.

Fixed in rev 45459.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.