Wireshark-bugs: [Wireshark-bugs] [Bug 7824] Failure to check return values from ws_fopen calls
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 10 Oct 2012 12:51:32 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7824

Guy Harris <guy@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9322|review_for_checkin?         |review_for_checkin+
              Flags|                            |

--- Comment #13 from Guy Harris <guy@xxxxxxxxxxxx> 2012-10-10 12:51:32 PDT ---
Comment on attachment 9322
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=9322
Patch to packet-asn1.c

The rest of the code already checks for namelist being null, so it's OK to call
build_tree_view() - and it may be necessary to do so, as the code below might
assume that's worked.

However, we should not call fclose() on namelist if it's null; the C89
standard, at least, does *not* assert that fclose(NULL) is a no-op.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.