Wireshark-bugs: [Wireshark-bugs] [Bug 7803] Invalid memory accesses when loading radius captures
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7803
--- Comment #6 from Evan Huus <eapache@xxxxxxxxx> 2012-10-06 15:28:32 PDT ---
(In reply to comment #5)
> Some of those may be due to dictionary.compat, which provides additional names
> for given codes, for compatibility; those may be useful if you're reading files
> that have RADIUS entries by name and need to translate them to codes, but I
> think we're translating codes to names, so they may not be necessary.
> (However, if I remove radius/dictionary.compat, Wireshark crashes with a memory
> corruption error, that I'm trying to track down; Evan's change doesn't fix that
> - I'm not sure what's causing the trashing; it's happening in a free call.)
It's because radius/dictionary still has the line "$INCLUDE dictionary.compat".
We should be erroring properly instead of dumping core, but commenting out that
line works around the issue.
> Some others are duplicates within dictionary.redback; there's a comment there:
>
> #
> # Redback Vendor Specific Extensions
> #
> # The first set here uses '_' as the separator, as Redback has changed
> # their documentation to use '-' vs. '_'. The older '_' style entries
> # are listed first so that they will still be accepted,
> # yet not preferred.
>
> so this is probably another case of "useful for translating from names to
> codes, useless for translating codes to names".
And if I understand correctly, this means we should be preferring later entries
the way we already do.
> Multiple RADIUS entries for code 126: old Operator-Name, new Multi-Link-Flag
>
> looks like a case of a code being reused - Operator-Name is from
> dictionary.rfc5580, i.e. "defined by RFC 5580", and Multi-Link-Flag is from
> dictionary.usr:
>
> # Taken from the dictionary included with the USR RADIUS server,
> # and adjusted a bit.
>
> so maybe U.S. Robotics used that code but didn't register it in any way to keep
> RFC 5580 from reusing it. That may be one of those "needs a preference" cases.
This should possibly be something done as a UAT?
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
