Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 7771] Selecting a TCP Stream Graph causes Wireshark to crash

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7771

Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9261|                            |review_for_checkin?
              Flags|                            |

--- Comment #6 from Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> 2012-10-01 14:21:57 PDT ---
Created attachment 9261
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=9261
Save/restore cairo context instead of destroying

(In reply to comment #5)
> Created attachment 9260 [details]
> Patch that restores old behaviour for drawing ellipses
> 
> This makes drawing ellipses (circle points) work again, although it is fairly
> slow.  I will try later to see if there is a way to avoid creating and
> destroying the context over and over again.

draw_element_ellipse() makes some transformations [cairo_translate(),
cairo_scale()], which are not restored after call.

Attaching patch which use cairo_save/cairo_restore + remove cairo_stroke() when
not needed.
I'm not sure how faster (or slower) it is compared to creating/destroying cairo
context.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.