Wireshark-bugs: [Wireshark-bugs] [Bug 7772] New: [PATCH] dissect only the number of active subca
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 30 Sep 2012 05:01:12 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7772

           Summary: [PATCH] dissect only the number of active subcarriers
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Dissection engine (libwireshark)
        AssignedTo: bugzilla-admin@xxxxxxxxxxxxx
        ReportedBy: florian@xxxxxxxxxxx


Created attachment 9251
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=9251
Patch to properly dissect the number of active sub-carriers

Build Information:
wireshark 1.9.0 (SVN Rev 45218 from /trunk)

Copyright 1998-2012 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with GTK+ 2.24.10, with Cairo 1.10.2, with Pango 1.30.0, with
GLib 2.32.3, with libpcap, with libz 1.2.3.4, without POSIX capabilities,
without libnl, without SMI, without c-ares, without ADNS, without Lua, without
Python, with GnuTLS 2.12.14, with Gcrypt 1.5.0, without Kerberos, without
GeoIP,
without PortAudio, with AirPcap.

Running on Linux 3.2.0-31-generic, with locale fr_FR, with libpcap version
1.1.1, with libz 1.2.3.4, GnuTLS 2.12.14, Gcrypt 1.5.0, without AirPcap.

Built using gcc 4.6.3.

--
The dissector currently dissects all 1156 sub-carriers available in the Tone
Map Characteristisc Confirmation frame no matter what is the number of active
ones. 

This is not valid, because the frame only contains the number of active
sub-carriers, even though it is padded to 1156 sub-carriers. This is also an
issue for newest HomePlug AV devices with a 500Mbits/sec PHY rate, because
those will have up to 2690 sub-carriers, and we would only dissect the first
1156 active ones.

The patch attached fixes the issue, and also cleans up the mask used for the
"High" part of the sub-carrier modulation to match (modulus the 4-bits
shifting) the one used for the "Low" part.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.