Wireshark-bugs: [Wireshark-bugs] [Bug 3277] VoIP calls statistics shows incorrent "Rejected call
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 22 Sep 2012 11:38:45 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3277

Chris Maynard <christopher.maynard@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9204|                            |review_for_checkin?
              Flags|                            |

--- Comment #2 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2012-09-22 11:38:44 PDT ---
Created attachment 9204
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=9204
Patch that displays a sane value for the number of rejected calls.

I'm not sure if this is the right way to solve this bug.  It simply ignores the
rejected_calls value entirely and computes it instead.

But, if we're not going to use rejected_calls and we're just going to compute
it as I've done in the patch, then references to rejected_calls should also be
removed from ui/gtk/voip_calls.h and ui/gtk/voip_calls_dlg.c as well.

Maybe a VOIP expert could have a look first before a commit is made?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.