Wireshark-bugs: [Wireshark-bugs] [Bug 7708] Correcting a few fields in SDH dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 19 Sep 2012 19:58:57 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7708

--- Comment #7 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2012-09-19 19:58:57 PDT ---
Comment on attachment 9158
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=9158
patch2

stype_vals_blah ... is that really the best name?  What about sdh_s1_vals?

Better to use proto_tree_add_uint_format_value() instead of
proto_tree_add_uint_format() for hf_sdh_b2 ... or even better to eliminate the
duplicate b2 assignments that Alexis noted in comment 6 and then just use
proto_tree_add_item() instead.

"proto_tree_add_uint(sdh_tree, hf_sdh_au, tvb, 0+(3*level*COLUMNS), 9, au);"
... why is the length set to 9?  au is comprised of h2 and bits from h1, but h1
and h2 are within 4 bytes of each other, so shouldn't it just be 4?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.