Wireshark-bugs: [Wireshark-bugs] [Bug 7729] Full support of RFC2428 in FTP dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 18 Sep 2012 14:14:51 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7729

--- Comment #9 from Martin Kaiser <wireshark@xxxxxxxxx> 2012-09-18 14:14:50 PDT ---
Hi,

I fuzz-tested your patch, it crashes repeatedly. I'll upload a sample pcap so
you can investigate the crash.

I suppose it's related to

for (e = p + linelen;e != NULL && e > p && *e != '\n' && *e != \r';e--)         

where the check for the lower bound does not work correctly.

I just found epan/strutil.c, could you use find_line_end() to detect the end
and go back one char?

Or could you assume that the parameter you parse in parse_eprt_request() always
starts with the delimiter so you don't have to search for the last character of
the line?

Regards,

   Martin

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.