Wireshark-bugs: [Wireshark-bugs] [Bug 7728] Apply as Filter on ieee 802.11 packets gets the filt
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7728
Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
CC| |darkjames-ws@xxxxxxxxxxxx
Resolution|FIXED |
--- Comment #7 from Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> 2012-09-17 09:53:00 PDT ---
Reopening.
What about other macros like: CMP_ADDRESS, COPY_ADDRESS, ... ?
Should they also compare/copy subtypes?
To be honest, I don't like address_stype enum, why don't we have AT_ETHER_WLAN,
AT_ETHER_FDDI, etc..?
If we add new types to address_type compiler will generate warning for each
switch (addr->type) [easier maintenance Yay!].
There's lot of other problems with addr->type,
for example check build_conversation_filter() [used to filter/colorize ethernet
conversation]
318 case(CONV_ETHER):
319 /* XXX - is this the right way to check for Ethernet? */
320 /* check for the data link address type */
321 /* (ethertype will be 0 when used as length field) */
322 if (pi->dl_src.type != AT_ETHER) {
^^^^^^^^ (and no checking for .subtype)
323 if (show_dialog) {
324 simple_dialog(ESD_TYPE_ERROR, ESD_BTN_OK,
325 "Error filtering conversation. Please make\n"
326 "sure you have a Ethernet packet selected.");
327 }
328 return NULL;
329 }
330
331 if( pi->dl_src.type == AT_ETHER && pi->dl_dst.type == AT_ETHER ) {
333 buf = g_strdup_printf("eth.addr eq %s and eth.addr eq %s",
^^^^^^^^ ^^^^^^^^
336 } else {
337 return NULL;
338 }
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
