Wireshark-bugs: [Wireshark-bugs] [Bug 7715] Bluetooth: Add SAP dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 12 Sep 2012 06:50:18 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7715

--- Comment #6 from Martin Kaiser <wireshark@xxxxxxxxx> 2012-09-12 06:50:17 PDT ---
Comment on attachment 9133
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=9133
[PATCH 2/3] iso7816: Add subdissector ISO 7816-3

Hi,

I'm happy with sharing the ATR code and making it a separate protocol.

Like the others writing on -dev, I don't think that the true/false data
parameter is a good choice. Basically, you want to know if the packet is coming
from you blutooth protocol and change the col_info  entry accordingly. Why
don't you look at proto->layer_names for this?

Regards,

   Martin

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.