Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 7711] New: Add automatic L2TPv3 session setting detection

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7711

           Summary: Add automatic L2TPv3 session setting detection
           Product: Wireshark
           Version: SVN
          Platform: x86
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Dissection engine (libwireshark)
        AssignedTo: bugzilla-admin@xxxxxxxxxxxxx
        ReportedBy: celston@xxxxxxxxxxx


Created attachment 9113
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=9113
Patch adds L2TPv3 session setting autodetection.

Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
The attached patch enables Wireshark to track the session settings negotiated
by L2TPv3 LCCEs during the session setup messages. This means that rather than
requiring the user to specify these via the protocol settings dialog, in many
cases the dissected capture will 'just work'.

I have added the new option 'Detect' to the Protocol Preferences menu for the
'Cookie Size', 'L2-Specific Sublayer' and 'Decode L2TPv3 packet contents as...'
settings.

If 'Detect' is selected, then Wireshark will use the settings determined
automatically. Each L2TPv3 session may have different settings for these values
(when auto-detected).

The detected values may be overidden by selecting something other than 'Detect'
in the context menu.

So, some questions for this feature:

- Is 'Detect' the appropriate word in this context? 
- Would it be useful or counter-intuitive to show the detected settings
somewhere in the proto tree for dissected L2TPv3 data packets?
- By overriding a detected value in the context menu, it overrides the setting
on a protocol-wide, rather than a conversation basis. Can anyone think of a way
from the UI to override the setting per-conversation?

Fuzzed to ~1000 iterations with the attached pcaps.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.