Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 3534] IETF ForCES(Forwarding and Control Element Separation) dissector

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3534

Michael Mann <mmann78@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mmann78@xxxxxxxxxxxx

--- Comment #13 from Michael Mann <mmann78@xxxxxxxxxxxx> 2012-09-06 05:10:30 PDT ---
(In reply to comment #11)
> col_set_str(pinfo->cinfo, expert_add_info_format, ... must be also called when
> tree == NULL.

I don't understand this comment.  I thought most tree == NULL checks where for
still processing a packet even though you didn't need it displayed (like for
converstations, states, etc).  This dissector is strictly for "display", which
is why the tree == NULL check is so early.  Should I just move the 

col_set_str(pinfo->cinfo, COL_PROTOCOL,  "ForCES");
col_clear(pinfo->cinfo, COL_INFO);

lines into dissect_forces_tcp() and dissect_forces_not_tcp()?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.