Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 6950] openSAFETY - Malformed packets disable the dissector for the WS session

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6950

Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darkjames-ws@xxxxxxxxxxxx

--- Comment #12 from Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> 2012-09-03 05:37:04 PDT ---
Roland FYI,

In r44748 I commented out part of your r43109.

Inside proto_reg_handoff_opensafety() you registered end routine for frame:

+ /* registering frame end routine, to prevent a malformed dissection
preventing
+  * further dissector calls (see bug #6950) */
+ register_frame_end_routine(reset_dissector);


I don't quite get why you call register_frame_end_routine() when not dissecting
frame, and it'd be great if you could verify if still work.


Looking at the code, I think register_frame_end_routine() should be called when
you change bDissector_Called_Once_Before, and not inside
opensafety_package_dissector()

[case: if tvb_get_guint8() will throw exception, bDissector_Called_Once_Before
will always be TRUE]


Sorry for trouble.
Regards,
 Jakub.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.