Wireshark-bugs: [Wireshark-bugs] [Bug 7686] New: refactoring of packet-gsm_rlcmac
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 2 Sep 2012 02:26:41 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7686

           Summary: refactoring of packet-gsm_rlcmac
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Low
         Component: Wireshark
        AssignedTo: bugzilla-admin@xxxxxxxxxxxxx
        ReportedBy: wireshark@xxxxxxxxxxxxxxx


Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
I have previously made several enhancements to this dissector, and intend to
make some more enhancements to improve functionality and output formatting, but
I would like to do some refactoring first:

* most of the declarations in packet-gsm_rlcmac.h are only referenced in
packet-gsm_rlcmac.c, and should be moved to the C file.

* there are many duplicate hf definitions, it seems that the author has a
separate hf for each IE for every PDU it occurs in, for example there are 40+
hf_xxx_message_type hfs, where message type is a single enum with 40+ values.

* very few of the enumerated type IEs have value string definitions.

My intention for this bug is to only make cosmetic changes, to make reviewing
easier.

Any comments before I get stuck in?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.