Wireshark-bugs: [Wireshark-bugs] [Bug 7675] Bluetooth: Add AVCTP dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 30 Aug 2012 02:13:05 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7675

Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darkjames-ws@xxxxxxxxxxxx

--- Comment #8 from Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> 2012-08-30 02:13:04 PDT ---
+ val_to_str(cr, cr_vals, "unknown"), ...
  val_to_str(packet_type, packet_type_vals, "unknown packet type"));

val_to_str() takes format string as third argument, for displaying actual
unknown value. It should be something like: "unknown packet type (%u)",
if you don't want value it should be: val_to_str_const(..., "unknown packet
type")

Anyway, you specified all possible values, so no unknown values (for now).


You could also use AVCTP_PACKET_TYPE_* defines instead of numeric values for
packet_type_vals.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.