Wireshark-bugs: [Wireshark-bugs] [Bug 7639] Bluetooth minor enhancement
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 21 Aug 2012 07:07:17 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7639

--- Comment #23 from Michael Mann <mmann78@xxxxxxxxxxxx> 2012-08-21 07:07:17 PDT ---
(In reply to comment #21)
> (In reply to comment #20)
> > Perhaps patches 5-8 should be a single patch as it's one operation?  If others
> > agree with your logic, I would think all would be moved (or the patch rejected
> > again)
> Why one operation? I create 5 patches to speed up review process, so you have 5
> operations. But without one of patches rest may not apply, so that is reason
> why I numbered patches.

To me the one operation is "take the DUN, SPP, HFP dissectors out of RFCOMM and
make them their own files".  I can't do one without the other (otherwise I
would lose functionality) and since there are no actual code changes (if I read
the other comments correctly), I don't see why this couldn't be a single patch
especially since the patches weren't that big to begin with.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.