https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7639
--- Comment #21 from Michal Labedzki <michal.labedzki@xxxxxxxxx> 2012-08-21 06:28:11 PDT ---
(In reply to comment #19)
> Comment on attachment 8963 [details]
> [PATCH 5/9] Bluetooth: Remove DUN, HFP, SPP dissectors from RFCOMM
>
> Resetting review flag per comment #18. Letting someone else make the call.
What about patches 1-2? I do not see any your arguments for rejecting. Could
you explain what is wrong for you?
(In reply to comment #20)
> Perhaps patches 5-8 should be a single patch as it's one operation? If others
> agree with your logic, I would think all would be moved (or the patch rejected
> again)
Why one operation? I create 5 patches to speed up review process, so you have 5
operations. But without one of patches rest may not apply, so that is reason
why I numbered patches.
Everybody:
try "make bluetooth-plugins" to see how speed building dissectors can be (and
of course "touch" one of Bluetooth dissectors). On the other hand if you know
better way to do that please provide me solution. Then try the same but use
conventional "make".
Michael, do not you like Bluetooth?
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
