Wireshark-bugs: [Wireshark-bugs] [Bug 7639] Bluetooth minor enhancement
Date: Mon, 20 Aug 2012 23:06:58 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7639

--- Comment #18 from Michal Labedzki <michal.labedzki@xxxxxxxxx> 2012-08-20 23:06:57 PDT ---
(In reply to comment #15)
> Comment on attachment 8963 [details]
> [PATCH 5/9] Bluetooth: Remove DUN, HFP, SPP dissectors from RFCOMM
> 
> You complain about the 1100 dissector files, yet you want to break an existing
> one into 3 more files?

No, no, no, no. Firstly I am not complaining about ~1100 dissector files, but
buildtime for ~1100 plugins when I change only one - 20-30 seconds, too long,
there is Wireshark mechanism named "plugins" and there is possible to build in
0-2 seconds. Secondly please look at this patch again, because there is mistake
in mentioned file. packet-btrfcomm.c should not contain "logical-separated
dissectors" for DUN, SPP, HFP. For example HFP is not related to RFCOMM in its
layer at all. Moreover I thinking about some improvements for HFP, because this
is important dissector, so code will grow.

PS. I am happy that there are ~1100 dissectors in Wireshark :) Moreover, 2000
dissectors will be great.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.