https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7639
--- Comment #11 from Evan Huus <eapache@xxxxxxxxx> 2012-08-19 20:37:53 PDT ---
Hi Michal, thanks for all of the work you've done on these patches. I haven't
had time to do a proper review yet (and might not for a while, so if another
dev wants to grab this please feel free), however I do have a few initial
thoughts and questions:
- Does patch #1 make any actual logical changes, or is it simply moving the
dissectors to their own directory and making the appropriate build changes? It
will be much faster to review if I don't have to worry about any logical
changes to the dissectors themselves.
- We've been trying to avoid using plugin dissectors in the Wireshark source,
as they don't integrate into the packaging and distribution as nicely and are
more prone to getting out of sync with the installed Wireshark version. I'm
surprised that you're finding Wireshark's build system slow - a 'hot' re-build
of one dissector my box takes well under 30 seconds to complete. That's not
instantaneous, but it's not painfully slow either, especially given how big the
Wireshark tree is (and how long an initial clean build takes). All that is to
say, it's unlikely that the plugin-izing of dissectors that are already in-tree
will be accepted. We'd much rather take patches that speed up the build in
general :)
- If you could attach a few sample captures that can be used to test and
demonstrate your fixes and improvements, that would be greatly appreciated.
There are two small captures already at [1], but they are hardly comprehensive.
All the best,
Evan
[1] http://wiki.wireshark.org/SampleCaptures#Bluetooth
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
