Wireshark-bugs: [Wireshark-bugs] [Bug 7563] Capture file that crashes wireshark
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 9 Aug 2012 06:35:03 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7563

--- Comment #21 from Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> 2012-08-09 06:35:02 PDT ---
(In reply to comment #18)
> This patch should cover input
> validation for the VC Id and Link Rate fields properly.
> 
> Note link_rate==0 (unknown) is supported, as some hardware/firmware may not set
> this field, but vc_size==0 is defined invalid.

>From quick overview there's still problem when rate == 5.
 (writting to m_vc_index_array[4] when m_vc_index_array has only 4 elements)

Still I'm not happy with:
  in_fmt->m_vc_index_array[ rate - 1] = 0;
when rate == 0, so either this line should be not reached, or commented that
you know about this issue, but you don't care.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.