Wireshark-bugs: [Wireshark-bugs] [Bug 7493] Dissector for the Parrot AR Drone
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 30 Jul 2012 13:31:56 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7493

hildesht@xxxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8794|0                           |1
        is obsolete|                            |
   Attachment #8858|                            |review_for_checkin?
              Flags|                            |

--- Comment #12 from hildesht@xxxxxxxxxxx 2012-07-30 13:31:55 PDT ---
Created attachment 8858
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8858
Updated Patch

Hey Guys,

Here is my updated patch. I have fixed to the best of my knowledge almost
everything you guys commented about. 

I did not change the port because 5556 is the default port for the AR Drone AT*
commands.(see sec 6 pg 31 of the developers guide). 

I changed some of the items from FT_STRINGS to a more appropriate
representations of the values.

I removed as much of the unnecessary while/if statements as I could and used
value_strings where I could. 

I changed the function to return the number of bytes it dissected.

I hopefully removed all tabs with a spacing of 4 spaces per indent.

Hope this looks a lot better than it did before, let me know what you think :)

Thomas

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.