Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 7506] Analyze->Apply as Filter and Analyze->Prepare a Filter cause crashes

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7506

--- Comment #3 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2012-07-24 07:19:13 PDT ---
For the record, the problem is that the user data in the callbacks like

tree_view_menu_prepare_selected_cb(GtkAction *action _U_, gpointer user_data)

comes from the last parameter of gtk_action_group_add_actions() for the menu
bar
we don't add any user data. 
For the tree_view_menu_popup we add popup_menu_object. I think I'll hardcode
popup_menu_object in the filter callbacks rather than having all menu bar
callbecks receive popup_menu_object as user data.

From:
static void
tree_view_menu_prepare_selected_cb(GtkAction *action _U_, gpointer user_data)
{
    GtkWidget *widget = gtk_ui_manager_get_widget(ui_manager_tree_view_menu,
"/TreeViewPopup/PrepareaFilter/Selected");
    match_selected_ptree_cb( widget , user_data, MATCH_SELECTED_REPLACE);
}

to

static void
tree_view_menu_prepare_selected_cb(GtkAction *action _U_, gpointer user_data
_U_)
{
    GtkWidget *widget = gtk_ui_manager_get_widget(ui_manager_tree_view_menu,
"/TreeViewPopup/PrepareaFilter/Selected");
    match_selected_ptree_cb( widget , popup_menu_object,
MATCH_SELECTED_REPLACE);
}

That can then be backported to 1.8.2 and we can rethink the menu bar in 1.9.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.