Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 7518] Add new dissector for DVB-S2 Baseband Frame and GSE dissection

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7518

Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexis.lagoutte@xxxxxxxxx

--- Comment #3 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2012-07-23 06:59:56 PDT ---
Hi,
Look good but 

the code don't compile under Linux :
packet-dvb-s2-bb.c: In function 'dissect_dvb_s2_bb':
packet-dvb-s2-bb.c:659:17: error: 'gse_proto' may be used uninitialized in this
function [-Werror=uninitialized]
packet-dvb-s2-bb.c:564:22: note: 'gse_proto' was declared here

Also 1 clang Warning :
packet-dvb-s2-bb.c:851:9: warning: Value stored to 'byte' is never read

About the code with CRC, there is some fucntion in epan/crc* it is not possible
to use this function ?

Why some time you use proto_tree_add_uint* (line 774, 782...) and use
proto_tree_add_item ? (it is recommended to use proto_tree_add_item)


There is also a mistake in patch from CMake (epan/CMakeList.txt) wrong filename

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.