Wireshark-bugs: [Wireshark-bugs] [Bug 7377] Widgets are not properly expanded in gtk3
Date: Thu, 19 Jul 2012 06:20:32 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7377

--- Comment #21 from Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> 2012-07-19 06:20:32 PDT ---
Anders,

I have some conflict. In r43825 you commited:

ui/gtk/bootp_stat.c
        message_type_fr = gtk_frame_new("DHCP Message Type");
-       gtk_container_add(GTK_CONTAINER(vbox), message_type_fr);
+       gtk_box_pack_start(GTK_BOX (vbox), message_type_fr, FALSE, TRUE, 0);

In my tree it's:
+       gtk_box_pack_start(GTK_BOX (vbox), message_type_fr, TRUE, TRUE, 0);

Which works. This frame should expand (please test).

I'm not sure if I properly write my comment #19.
Safe replace (i.e. which gives the same effect in gtk2 and gtk3) is change
from:
  gtk_container_add(GTK_CONTAINER(box), widget);
to:
  gtk_box_pack_start(GTK_BOX(box), widget, TRUE, TRUE, 0);

You can set expand to FALSE for some widgets (like buttons) but generally
setting expand to TRUE is *safe* (in other cases you need to test it :-)).

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.