Wireshark-bugs: [Wireshark-bugs] [Bug 2695] New WiMAX OFDMA PHY SAP dissector
Date: Tue, 17 Jul 2012 05:27:20 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2695

Michael Mann <mmann78@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1980|0                           |1
        is obsolete|                            |
   Attachment #1980|review_for_checkin?         |
              Flags|                            |
   Attachment #4721|0                           |1
        is obsolete|                            |
   Attachment #4721|review_for_checkin?         |
              Flags|                            |
   Attachment #8788|                            |review_for_checkin?
              Flags|                            |

--- Comment #3 from Michael Mann <mmann78@xxxxxxxxxxxx> 2012-07-17 05:27:18 PDT ---
Created attachment 8788
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8788
Updated WiMAXMAXPHY dissector

Updated code to be a "modern" plugin.   Thought maybe this could be a built-in,
but there was already existing WiMax plugins, and I didn't really want to
convert them all without consultation.

Fixed the combinations of tvb_get_* + proto_tree_add_* and drastically reduced
the "whitespace".  More "whitespace" can be removed with reformatting of the hf
array (perl isn't my strong suit, but it appears someone has been reformatting
hf arrays on the trunk, but I don't see anything in the "tools" directory to do
it myself)

Wanted to work with the Python script to generate traffic to test dissector
before committing.  Any "real" traffic would also be appreciated.

Since I haven't written a plugin before, comments are certainly welcome.  I'm
fairly confident with the dissector code, its the other stuff I'm not sure I
updated correctly.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.