Wireshark-bugs: [Wireshark-bugs] [Bug 7407] Art-Net ESTA manufacturer codes are not labelled aft
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 5 Jul 2012 13:26:47 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7407

Pascal Quantin <pascal.quantin@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pascal.quantin@xxxxxxxxx

--- Comment #3 from Pascal Quantin <pascal.quantin@xxxxxxxxx> 2012-07-05 13:26:46 PDT ---
(In reply to comment #2)
> Created attachment 8721 [details]
> Updated ESTA manufacturer IDs + OEM code values
> 
> Updated the value_strings (and updated them to ext_value_strings).  
> 
> "endianness" of ESTA code has already been accounted for, but was kept as
> 16-bit value.

Following the update to ext_value_string, you lack the OR with BASE_EXT_STRING
in the hf fields.
It seems that some OEM codes (that were previously defined in packet-artnet.c)
do not match the current spec given in attachment 8684. Should they be updated
also? (if you feel courageous enough of course :))

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.