Wireshark-bugs: [Wireshark-bugs] [Bug 7428] Wireshark does not dissect NEGOEX, The Extended GSS-
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7428
--- Comment #6 from Richard Sharpe <realrichardsharpe@xxxxxxxxx> 2012-07-03 14:10:47 PDT ---
(In reply to comment #5)
> Hi Richard,
>
> a few remarks concerning your patch:
> - please use _U_ instead of __attribute__((unused)) so as to be portable across
> platforms
Heh, now I remember that.
> - The "The" in the protocol name seems a bit strange to me. Is "Extended
> GSS-API Negotiation Mechanism" enough?
I used the name from the draft RFC.
> - why use the volatile keyword for variables not inside and outside of a TRY
> block ? Did I miss something ?
Yeah, that was sloppy. I was cribbing from the SMB dissector, I think and not
paying attention to variables declared outside a TRY block but used within it,
which is where it would matter, I guess.
> As you seem to be actively working on the dissector, should we wait a bit
> before integrating it so as to get a more up-to-date version ?
Sure. Let me fix these few things and add dissection for the ALERT command and
fix one other thing.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
