Wireshark-bugs: [Wireshark-bugs] [Bug 7398] New: Simplify debugging ifdef in camel-persistantdat
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 23 Jun 2012 15:45:36 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7398

           Summary: Simplify debugging ifdef in camel-persistantdata.c
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Trivial
          Priority: Low
         Component: Dissection engine (libwireshark)
        AssignedTo: bugzilla-admin@xxxxxxxxxxxxx
        ReportedBy: eapache@xxxxxxxxx


Build Information:
wireshark 1.9.0 (SVN Rev Unknown from unknown)

Copyright 1998-2012 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with GTK+ 2.24.10, with Cairo 1.12.2, with Pango 1.30.1, with
GLib 2.33.2, with libpcap, with libz 1.2.3.4, with POSIX capabilities (Linux),
with SMI 0.4.8, with c-ares 1.9.1, with Lua 5.1, without Python, with GnuTLS
2.12.14, with Gcrypt 1.5.0, with MIT Kerberos, with GeoIP, with PortAudio
V19-devel (built Dec 10 2011 11:43:10), with AirPcap.

Running on Linux 3.5.0-1-generic, with locale en_CA.UTF-8, with libpcap version
1.3.0, with libz 1.2.3.4, GnuTLS 2.12.14, Gcrypt 1.5.0, without AirPcap.

Built using gcc 4.7.0.
--
Move the ifdefs to outside the if/else statement entirely. Not only is this
simpler, it prevents an empty if-block when DEBUG_CAMELSRT isn't set, which was
causing CppCheck to complain.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.