Wireshark-bugs: [Wireshark-bugs] [Bug 7349] RFC 4954 (SMTP Authentication)
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 10 Jun 2012 19:01:37 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7349

Michael Mann <mmann78@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8573|0                           |1
        is obsolete|                            |
   Attachment #8573|review_for_checkin?         |
              Flags|                            |
   Attachment #8582|                            |review_for_checkin?
              Flags|                            |

--- Comment #3 from Michael Mann <mmann78@xxxxxxxxxxxx> 2012-06-10 19:01:37 PDT ---
Created attachment 8582
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8582
RFC 4954 patch v2

Encorporated epan_base64_decode() into smtp dissector.  As I noted in bug 6102,
I don't think there's a bug in the algorithm, but I did modify it to NULL
terminate the decoded string.  Since by definition of the algorithm, the
resulting string will be smaller than the provided string, there shouldn't be
issues there.
Updated only dissector that uses epan_base64_decode() (packet-http.c) to assume
NULL termination.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.