Wireshark-bugs: [Wireshark-bugs] [Bug 7310] Initial support for the GlusterFS RPC-protocol
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7310
--- Comment #2 from Niels de Vos <ndevos@xxxxxxxxxx> 2012-06-01 02:32:48 PDT ---
Thanks for the feedback!
(In reply to comment #1)
> - C++ style comments are forbidden (packet-glusterfs.c, line 895)
Ah, this one slipped through, will be fixed when the FIXME parts are gone.
> - hf_gluster_op_ret and hf_gluster_op_errno have their filtername starting with
> gluster instead of glusterfs. Is it intended?
Yes it is, gluster_dissect_common_reply() uses these and will be called from
other dissectors for the gluster protocol series as well.
> - the last argument to proto_tree_add_bitmask() should be
> ENC_LITTLE_ENDIAN/ENC_BIG_ENDIAN and not TRUE/FALSE
Misunderstanding from my side, I'll update it.
> - your GFID seems to be displayed as a GUID. In that case why not use FT_GUID
> instead of creating a specific glusterfs_item_append_gfid function using
> multiple proto_item_append_text() calls?
Very nice, will use FT_GUID now.
> - packet-glusterfs.c needs to be added to epan/CMakeLists.txt file
Of course, I'll make sure its included in the next patch.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
