Wireshark-bugs: [Wireshark-bugs] [Bug 7310] Initial support for the GlusterFS RPC-protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 31 May 2012 08:56:24 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7310

Pascal Quantin <pascal.quantin@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pascal.quantin@xxxxxxxxx

--- Comment #1 from Pascal Quantin <pascal.quantin@xxxxxxxxx> 2012-05-31 08:56:24 PDT ---
Hi,

here are a first few comments:
- C++ style comments are forbidden (packet-glusterfs.c, line 895)
- hf_gluster_op_ret and hf_gluster_op_errno have their filtername starting with
gluster instead of glusterfs. Is it intended?
- the last argument to proto_tree_add_bitmask() should be
ENC_LITTLE_ENDIAN/ENC_BIG_ENDIAN and not TRUE/FALSE
- your GFID seems to be displayed as a GUID. In that case why not use FT_GUID
instead of creating a specific glusterfs_item_append_gfid function using
multiple proto_item_append_text() calls?
- packet-glusterfs.c needs to be added to epan/CMakeLists.txt file

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.