Wireshark-bugs: [Wireshark-bugs] [Bug 6986] Updating the RPL SRH dissector and implementing RPL
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 29 May 2012 23:16:25 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6986

anwilli5@xxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8511|0                           |1
        is obsolete|                            |
   Attachment #8511|review_for_checkin?         |
              Flags|                            |
   Attachment #8512|                            |review_for_checkin?
              Flags|                            |

--- Comment #13 from anwilli5@xxxxxxxx 2012-05-29 23:16:25 PDT ---
Created attachment 8512
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8512
Diff updating RPL SRH dissection and adding preference for strict RFC checking
- using memcmp for address comparisons

Thanks for the feedback... I was initially hesitant to use memcmp on the
addresses since they are stored as structs and I know that comparing structs
might get you into trouble due to padding sometimes being added by the
compiler.  Thinking about it more, though, since all that is needed is to
compare the 'bytes' arrays directly, there is no way that padding could
possible mess that up, so memcmp is a much better solution.  I apologize for
the mistake, and please let me know if there is anything else I should change. 
Thanks!

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.