Wireshark-bugs: [Wireshark-bugs] [Bug 7295] Misc dead code
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 27 May 2012 13:41:43 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7295

Guy Harris <guy@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8494|review_for_checkin?         |review_for_checkin+
              Flags|                            |

--- Comment #4 from Guy Harris <guy@xxxxxxxxxxxx> 2012-05-27 13:41:42 PDT ---
Comment on attachment 8494
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8494
Unused variable

I've checked in a change based on this that gets rid of the ret variable and
also fixes some other issues that turned up while looking at this
(vwr_read_rec_header() only needs to return a success/failure value, so I made
it return a gboolean, and if it returns VALSE in vwr_read(), vwr_read() should
*NOT* overwrite *err_info).

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.