Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 1257] "Save As ..." shouldn't reload the temp file

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1257

Guy Harris <guy@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|INVALID                     |

--- Comment #2 from Guy Harris <guy@xxxxxxxxxxxx> 2012-05-24 13:40:08 PDT ---
Actually, it shouldn't.

Ideally, as the file is being saved, the offsets in the frame_data structures
should be updated to point to the appropriate offsets in the new file (they
might be different from the offsets in the old file, if, for example, comments
were added, edited, or removed), and then Wireshark should switch to using the
new file when reading frame data.  That's tricky, however, if the save fails -
the offsets shouldn't be updated in place, a new set of frame_data structures
should be generated and that should replace the old set if the save succeeds.

If the file is being saved as a compressed file, it would also need to
regenerate the fast-seek tables.

A shorter-term improvement might be to, instead of *reloading* the file, just
*rescan* it, without doing any dissection, to just update the offsets and
rebuild the fast-seek tables.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.