Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 7266] Patch: Add frame.interface_id support for ERF file format

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7266

Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darkjames-ws@xxxxxxxxxxxx

--- Comment #4 from Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> 2012-05-17 11:24:13 PDT ---
(In reply to comment #2)
> Created attachment 8456 [details]
> Patch adding frame.interface_id support when reading ERF format files

It'd be good if you add:
   memset(&int_data, 0, sizeof(int_data)) 
cause we *might* add new fields to wtapng_if_descr_t struct.

+    int_data.if_name = g_malloc(IF_NAME_BUF_LEN);
+    snprintf(int_data.if_name, IF_NAME_BUF_LEN, "Port %c", 'A'+i);

int_data.if_name = g_strdup_printf("Port %c", 'A'+i);

+    int_data.if_description = g_malloc(IF_DESC_BUF_LEN);
+    snprintf(int_data.if_description, IF_DESC_BUF_LEN, "ERF Interface Id %d
(Port %c)", i, 'A'+i);

int_data.if_description = g_strdup_printf("ERF Interface Id %d (Port %c)", i,
'A'+i);

+#define IF_NAME_BUF_LEN 7
+#define IF_DESC_BUF_LEN 30

No longer needed.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.