Wireshark-bugs: [Wireshark-bugs] [Bug 7254] Enhancements for FPSpotlightRPC AFP function
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 15 May 2012 00:07:18 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7254

--- Comment #13 from Alexander Lüders <alexander.lueders@xxxxxx> 2012-05-15 00:07:18 PDT ---
(In reply to comment #11)
> (In reply to comment #9)
> > Ok, rebased the patch.
> 
> I've now taken a closer look at the patch and found an issue. At
> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8438&action=diff&headers=0#packet-afp.c_sec6
> line 4235 you're comparing an unsigned (mark_exists) with a signed (-1).
> I've fixes this in the patch I'll attach next. Please review and the mark for
> checkin.

You're right. Thanks for fixing. Looks much cleaner now.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.