Wireshark-bugs: [Wireshark-bugs] [Bug 7254] Enhancements for FPSpotlightRPC AFP function
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 14 May 2012 13:46:18 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7254

Alexander Lüders <alexander.lueders@xxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8426|0                           |1
        is obsolete|                            |
   Attachment #8426|review_for_checkin?         |
              Flags|                            |
   Attachment #8436|                            |review_for_checkin?
              Flags|                            |

--- Comment #6 from Alexander Lüders <alexander.lueders@xxxxxx> 2012-05-14 13:46:17 PDT ---
Created attachment 8436
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8436
patch

Actually, i had an error in the patch concerning the decrement of the count
value for the nested uint64/float/uuid/null structures. Removing the decrement
entirely is wrong too. The count has to be decrement by (number of elements in
the structures - 1) as count gets decremented by 1 further down in the
dissection loop.
Thus,

count -= j;
has to become 
count -= j - 1;

As the dissection loops stops when either count reaches 0 or it hits the ToC, i
did not recognize my error.

However, i corrected my patch and replaced the old one.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.