Wireshark-bugs: [Wireshark-bugs] [Bug 7247] IPX Traffic Mac Addresses
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 14 May 2012 07:33:06 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7247

Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darkjames-ws@xxxxxxxxxxxx

--- Comment #4 from Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> 2012-05-14 07:33:06 PDT ---
(In reply to comment #3)
> But bug is somewhere else.

Hm, 7eb4516342ca956cae4e79ad7ca8529db5f6e61d[1] or
e59abf81d3de639e389393989c7823ac8a68f663[2] in libpcap.

Let's look on 7eb45163:

+  struct vlan_tag *tag;
[...]
+  memmove(bp, bp + VLAN_TAG_LEN, 2 * ETH_ALEN /* 12 */);
+
+  tag = (struct vlan_tag *)(bp + 2 * ETH_ALEN);
+  tag->vlan_tpid = htons(ETH_P_8021Q);
+  tag->vlan_tci = htons(h.h2->tp_vlan_tci);
[...]

Correct (?) version:
+  memmove(bp, bp + VLAN_TAG_LEN, 14);
+  tag = (struct vlan_tag *)(bp + 14); ?

[1]
https://github.com/mcr/libpcap/commit/7eb4516342ca956cae4e79ad7ca8529db5f6e61d
[2]
https://github.com/mcr/libpcap/commit/e59abf81d3de639e389393989c7823ac8a68f663

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.