Wireshark-bugs: [Wireshark-bugs] [Bug 7237] Display guids in FPSpotlightRPC AFP packets
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 9 May 2012 02:19:42 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7237

--- Comment #5 from Frank Lahm <franklahm@xxxxxxxxxxxxxx> 2012-05-09 02:19:42 PDT ---
> Committed in revision 42515 (with the use of proto_add_item as suggested by
> Alexis).

Thanks!

(In reply to comment #4)
> As spotlight appears to be either big or little endian (detected by a magic),
> shouldn't the UUID dissection be:
> proto_tree_add_item(tree, hf_afp_spotlight_uuid, tvb, offset, 16, encoding);
> instead of:
> proto_tree_add_item(tree, hf_afp_spotlight_uuid, tvb, offset, 16,
> ENC_BIG_ENDIAN);
> ?

Probably not, because afair the wire format of a guid is a binary blob, not an
integral type.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.