Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 7205] Patch for IEEE 1722.1 AEM status field

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7205

Pascal Quantin <pascal.quantin@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pascal.quantin@xxxxxxxxx

--- Comment #1 from Pascal Quantin <pascal.quantin@xxxxxxxxx> 2012-04-27 01:27:08 PDT ---
Hi,

-   proto_tree_add_item(aecp_tree, hf_acmp_status_field, tvb,
+   proto_tree_add_item(aecp_tree, hf_aem_status_code, tvb,
          ACMP_STATUS_FIELD_OFFSET, 1, ENC_BIG_ENDIAN);
I guess you should introduce a AECP_STATUS_FIELD_OFFSET instead of reusing
ACMP_STATUS_FIELD_OFFSET, right?
BTW, as the item belongs to the AECP tree, why name it hf_aem_status_code and
not hf_aecp_status_code? Maybe this is perfectly right but as I do not have
access to the spec, I cannot check.

+      { &hf_aem_status_code,
+         {"Status", "ieee1722.status",
+            FT_UINT16, BASE_HEX, VALS(aem_status_type_vals), 0x00, NULL, HFILL
}
+      },
It should be FT_UINT8.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.