Wireshark-bugs: [Wireshark-bugs] [Bug 7197] Accelerators for "Expand Subtree", "Expand All" and
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7197
--- Comment #1 from Guy Harris <guy@xxxxxxxxxxxx> 2012-04-25 16:35:02 PDT ---
I'm not sure why the diffs are showing up in that fashion - perhaps whatever
SVN-to-Git mapper is being used is screwing up - but if you ask SVN what
changes were done by
r39082 | wmeier | 2011-09-21 11:55:03 -0700 (Wed, 21 Sep 2011) | 5 lines
Whitespace cleanup:
Use consistent indentation;
Convert "4 space tabs" to spaces;
Remove trailing whitespace.
and use "diff -w" so that whitespace changes aren't shown, you just get
Index: epan/uat.c
===================================================================
679c679
< * tab-width: 4
---
> * tab-width: 8
683,684c683,684
< * ex: set shiftwidth=4 tabstop=4 expandtab:
< * :indentSize=4:tabSize=4:noTabs=true:
---
> * ex: set shiftwidth=4 tabstop=8 expandtab:
> * :indentSize=4:tabSize=8:noTabs=true:
...
Index: epan/dissectors/packet-hdfs.c
===================================================================
1087c1087
< * c-basic-offset: 2
---
> * c-basic-offset: 4
1092,1093c1092,1093
< * ex: set shiftwidth=2 tabstop=8 expandtab:
< * :indentSize=2:tabSize=8:noTabs=true:
---
> * ex: set shiftwidth=4 tabstop=8 expandtab:
> * :indentSize=4:tabSize=8:noTabs=true:
so that change really *did* just tweak whitespace and change some modelines to
match - it didn't do anything with the menus themselves. (As the official
Wireshark source repository uses SVN, SVN is the authoritative source here.)
menus.c disappeared in rev 39137:
r39137 | jmayer | 2011-09-25 14:19:45 -0700 (Sun, 25 Sep 2011) | 4 lines
We now always build with MAIN_MENU_USE_UIMANAGER, so remove all code using
the old ways except the proto_help.c file, which is kept for now in case
someone
is willing to reimplement the help menus using non-deprecated methods.
An "svn blame" of ui/gtk/main_menubar.c doesn't seem to show any lines where
there was any accelerator for "Expand All", so perhaps it disappeared with the
changes to use GtkUIManager. Unfortunately, with the disappearance of
ui/gtk/menus.c from the source, it doesn't appear to be easy to run "svn blame"
on it to see when it disappeared.
*However*, as a comment in main_menubar.c says:
/*
* Main menu.
*
* Please do not use keystrokes that are used as "universal" shortcuts in
* various desktop environments:
*
* Windows:
* http://support.microsoft.com/kb/126449
*
* GNOME:
* http://library.gnome.org/users/user-guide/nightly/keyboard-skills.html.en
*
* KDE:
*
http://developer.kde.org/documentation/standards/kde/style/keys/shortcuts.h$
*
* In particular, do not use the following <control> sequences for anything
* other than their standard purposes:
*
* <control>O File->Open
* <control>S File->Save
* <control>P File->Print
* <control>W File->Close
* <control>Q File->Quit
* <control>Z Edit->Undo (which we don't currently have)
* <control>X Edit->Cut (which we don't currently have)
* <control>C Edit->Copy (which we don't currently have)
* <control>V Edit->Paste (which we don't currently have)
* <control>A Edit->Select All (which we don't currently have)
*
* Note that some if not all of the Edit keys above already perform those
* functions in text boxes, such as the Filter box. Do no, under any
* circumstances, make a change that keeps them from doing so.
*/
so, whilst having *some* accelerators for "Expand Subtrees" and "Collapse All"
would be useful, control-A as an accelerator could get in the way of, for
example, selecting all the packets and then copying to the clipboard as, for
example, a list of the packet summary lines, which might be a useful operation.
Control-X for "Expand Subtrees" might be less of a problem, but it's still
probably best not to poach it.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
