Wireshark-bugs: [Wireshark-bugs] [Bug 7061] New Dissector: Binary Floor Control Protocol (BFCP)
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 19 Apr 2012 15:23:24 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7061

patrick.white@xxxxxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8268|0                           |1
        is obsolete|                            |
   Attachment #8268|review_for_checkin?         |
              Flags|                            |

--- Comment #19 from patrick.white@xxxxxxxxxxxxx 2012-04-19 15:23:23 PDT ---
Created attachment 8278
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8278
Updated bfcp over UDP patch

I added all the suggestions to the patch:

- fixed comment about first byte
- used gint instead of int
- did not use c++ style comments
- renamed the function to dissect_bfcp from dissect_bfcp_tcp
- show the remainder of the payload that wasn't dissected.

I also completed the loop so it shows all the attributes instead of just the
first one.

Looking good now?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.