Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 7061] New Dissector: Binary Floor Control Protocol (BFCP)

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7061

--- Comment #15 from Pascal Quantin <pascal.quantin@xxxxxxxxx> 2012-04-18 13:38:48 PDT ---
(In reply to comment #13)
> Created attachment 8268 [details]
> patch to add UDP to bfcp dissectors.
> 
> Thanks for this dissector! 
> 
> I have a patch that adds the new fields found in the new UDP draft for BFCP
> over UDP ( http://tools.ietf.org/html/draft-sandbakken-dispatch-bfcp-udp-03 ).
> It adds some new primitives and decodes the attribute type. There is still some
> more work to be done, but figured I should upload it before someone else
> continues to work on it.

Hi,

This hunk seems suspicious:
-    if (first_byte != 0x20)
+    if (first_byte != 0x20 && first_byte != 0x30 )
         return FALSE;

If hf_bfcp_payload is no more used, simply remove it:
+//                proto_tree_add_item(bfcp_tree, hf_bfcp_payload, tvb,
+//                BFCP_OFFSET_PAYLOAD, bfcp_payload_length,
+//                ENC_NA);
Or should it be used to display the remaining bytes of the payload after
analyzing the 2/3 first bytes?

If the protocol can run on UDP also, it's probably time to rename the
dissection function:
+        heur_dissector_add ("udp", dissect_bfcp_tcp, proto_bfcp);

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.