Wireshark-bugs: [Wireshark-bugs] [Bug 1450] irc dissector don't show CTCP commands
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1450
Michael Mann <mmann78@xxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mmann78@xxxxxxxxxxxx
--- Comment #12 from Michael Mann <mmann78@xxxxxxxxxxxx> 2012-04-13 05:17:53 PDT ---
(In reply to comment #11)
> Toralf,
> Is there any reason why you are using tvb_pbrk_guint8()?
> It looks like you are only searching for just one character.
> Can you rewrite it to use tvb_find_guint8()?
That was me, and it was a "copy/paste" thing from looking at
tvb_find_line_end(). I was unaware of tvb_find_guint8(), but I was also
concerned about "delimiting the delimiter character" mentioned in teh CTCP
spec, so I thought tvb_pbrk_guint8() would be needed for a "more generic"
solution.
CTCP appears to be written genericlly enough that I don't think its limited to
the /001 delimiter, but I wasn't sure how far to take it. That was one of the
reasons I didn't include a CTCP dissector specifically. It looks like it
could run over protocols other than IRC, making it a candidate for its own
source file. I put the initial patch out there for Toralf or others to use to
test out the "CTCP delimiter logic" more than anything. The CTCP protocol
itself doesn't seem that complicated to write a dissector for.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.
