Wireshark-bugs: [Wireshark-bugs] [Bug 7061] New Dissector: Binary Floor Control Protocol (BFCP)
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 11 Apr 2012 11:36:06 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7061

--- Comment #9 from Nitinkumar Yemul <nitinkumaryemul@xxxxxxxxx> 2012-04-11 11:36:05 PDT ---
(In reply to comment #7)
> Two small questions:
> 
> - Why is your heuristic dissector returning:
>     return tvb_length(tvb);    
> instead of:
>     return TRUE;    
> ?
I followed multiple packet dissectors some of which are non-heuristic.Should I
change it to TRUE? 

> 
> - Can you have a packet bigger than 12 bytes? You only dissect 12 bytes so it
> could allow to narrow the heuristics.

Yes, we can have BFCP packet bigger than 12 bytes. 

Header - 12 bytes
Payload - depends on 'payload_length' in header.

As of now I am only dissecting header, and thinking to add complete message
dissection code in next iteration.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.