Wireshark-bugs: [Wireshark-bugs] [Bug 7052] New: DVB-CI host control: dissect pmt section by cal
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 9 Apr 2012 14:06:04 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7052

           Summary: DVB-CI host control: dissect pmt section by calling
                    mpeg_pmt dissector
           Product: Wireshark
           Version: SVN
          Platform: x86
        OS/Version: All
            Status: NEW
          Severity: Major
          Priority: Low
         Component: Wireshark
        AssignedTo: bugzilla-admin@xxxxxxxxxxxxx
        ReportedBy: wireshark@xxxxxxxxx


Build Information:
TShark 1.7.2 (SVN Rev 42000 from /trunk)

Copyright 1998-2012 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with GLib 2.24.2, with libpcap, with libz 1.2.3.4, without
POSIX capabilities, without SMI, without c-ares, without ADNS, without Lua,
without Python, with GnuTLS 2.8.6, with Gcrypt 1.4.5, with MIT Kerberos,
without
GeoIP.

Running on Linux 2.6.32-5-amd64, with locale en_US.UTF-8, with libpcap version
1.1.1, with libz 1.2.3.4.

Built using gcc 4.4.5.

--

Dear all,

@Anders: thanks for merging the oipf patch.

in DVB-CI/CI+, there's one apdu that contains a PMT (program map table) as part
of the message. As we have a dissector for mpeg_pmt, it would be useful to call
it for dissecting such a pmt.

The issue I've had with this was that the mpeg_pmt dissector clears the info
column and sets it to "Program Map Table". That makes sense if we dissect a
transport stream where a packet contains only a pmt but not if the pmt is part
of a DVB-CI message.

My solution is to use p_add_proto_data() and p_get_proto_data(). The DVB-CI
dissector sets some random data for its protocol, the mpeg_pmt dissector checks
if DVB-CI has seen the packet before and doesn't touch the info column in this
case.

Thanks for review and merging, as usual.

Best regards,

   Martin

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.