Wireshark-bugs: [Wireshark-bugs] [Bug 6878] Overhaul of tvb_get_bitsxx() functions
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 4 Apr 2012 10:20:04 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6878

--- Comment #12 from Mike Morrin <wireshark@xxxxxxxxxxxxxxx> 2012-04-04 10:20:04 PDT ---
(In reply to comment #11)
> 
> Is Coverity pacified by adding an assertion to this effect?
How about rplacing line 1786 with:

value = (tvb_get_guint8(tvb, octet_offset) >> right_shift) &
bit_mask8[total_no_of_bits%8];

That would be functionally equivalent, and should shut up the analysis tools.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.