Wireshark-bugs: [Wireshark-bugs] [Bug 7020] Review use of proto_tree_add_text in packet-eap.c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 3 Apr 2012 17:54:14 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7020

Nick Lowe <nick.lowe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8145|                            |review_for_checkin?
              Flags|                            |

--- Comment #5 from Nick Lowe <nick.lowe@xxxxxxxxx> 2012-04-03 17:54:14 PDT ---
Created attachment 8145
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8145
Convert EAP-IDENTITY, EAP-NOTIFY and EAP-MD5 to use proto_tree_add_item().

Second patch covering the identity, notify and MD5 EAP types.
Also disambiguated the EAP-TLS length name and tidied.

eapid, eapnotify, eapmd5.value_size and eapmd5.value are new.

I am looking at the LEAP EAP type now, is there a security/crash issue with it
blindly passing the count to proto_tree_add_text() having previously just read
it in without any sanity checks?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.